Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to investigate removal of .promise() #859

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 11, 2024

Issue

Fixes: #697

Description

Add comment to investigate removal of .promise()

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Apr 11, 2024

🦋 Changeset detected

Latest commit: ea31b5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trivikr trivikr marked this pull request as ready for review April 12, 2024 00:40
@trivikr trivikr requested a review from a team as a code owner April 12, 2024 00:40
@trivikr trivikr merged commit 06a91b7 into main Apr 12, 2024
6 checks passed
@trivikr trivikr deleted the orphan-promise branch April 12, 2024 00:45
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: If codemod comes across .promise() calls, add a comment for developer to check if it can be removed
1 participant